Wireshark-commits: [Wireshark-commits] master c9c33af: Add more checks, fail for negative byte bloc
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 27 Oct 2019 23:00:16 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c9c33affd977806457e8bea6f45597587db3b8c3
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

c9c33af by Guy Harris (guy@xxxxxxxxxxxx):

    Add more checks, fail for negative byte block lengths.
    
    Have dissect_kafka_string_new() set a flag if the length was negative.
    If the length is negative, don't try to process what comes afterwards.
    
    Make the length argument to decompression routines unsigned, and do
    various checks.  Don't try to decompress a zero-length block, and quit
    if the decompressed block is zero-length.
    
    Bug: 16082
    Change-Id: I34c2ea99aa096b3f5724d9b113171b105bd6c60b
    Reviewed-on: https://code.wireshark.org/review/34867
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  7995b45   Qt: Respect saved extcap multiselect configuration
     add  c9c33af   Add more checks, fail for negative byte block lengths.


Summary of changes:
 epan/dissectors/packet-kafka.c | 69 ++++++++++++++++++++++++++++++------------
 1 file changed, 50 insertions(+), 19 deletions(-)