Wireshark-commits: [Wireshark-commits] master 829d2c3: synphasor: fix compilation with gcc-5/6.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 26 Oct 2019 20:39:57 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=829d2c3752b760d33ba4234361ac39acb2831091
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

829d2c3 by Dario Lombardo (lomato@xxxxxxxxx):

    synphasor: fix compilation with gcc-5/6.
    
    They complain because of an uninitialized variable.
    
    ../epan/dissectors/packet-synphasor.c: In function ‘config_3_frame_fast’:
    ../epan/dissectors/packet-synphasor.c:782:7: error: ‘ai’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
         ai[i].conv = 1;
           ^
    ../epan/dissectors/packet-synphasor.c:767:7: error: ‘pi’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
         pi[i].unit = phasor_unit & 0x00000800 ? A : V;
           ^
    
    Change-Id: I2013ca9ddff5551328d2b86decc5e52fe052b6d0
    Reviewed-on: https://code.wireshark.org/review/34859
    Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx>
    Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  04e660d   nfs: fix guint64 format in proto_item_append_text.
     add  829d2c3   synphasor: fix compilation with gcc-5/6.


Summary of changes:
 epan/dissectors/packet-synphasor.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)