Wireshark-commits: [Wireshark-commits] master-3.0 184a989: SNMP: handle Net-SNMP Engine Id of 12 oc
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 23 Oct 2019 04:10:10 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=184a9891705d827fb6561cdd4b54a1b238d16327
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

184a989 by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    SNMP: handle Net-SNMP Engine Id of 12 octets
    
    The Net-SNMP code creates an Engine Id size based on the compilation
    size, either 8 or 12 octets long. The initial change added handling of
    the '4B/8B random, 4B epoch seconds' format. A different format seems
    more likely though, hence this change, implementing handling of the
    '4B random, 4B/8B epoch seconds' format instead.
    
    Bug: 16051
    Change-Id: I8105b0ba69004f6c15e6b1926c677cb4c5b76f17
    Reviewed-on: https://code.wireshark.org/review/34816
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    (cherry picked from commit 54fac1e3097142062f5ed8e1d34ed5a247d9ed70)
    Reviewed-on: https://code.wireshark.org/review/34831
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  b2ab5c1   tools: Add update-appdata.py
     add  184a989   SNMP: handle Net-SNMP Engine Id of 12 octets


Summary of changes:
 epan/dissectors/asn1/snmp/packet-snmp-template.c | 15 ++++++++++-----
 epan/dissectors/packet-snmp.c                    | 21 +++++++++++++--------
 2 files changed, 23 insertions(+), 13 deletions(-)