Wireshark · Wireshark-commits: [Wireshark-commits] master f67ecce: Qt: Do not spin unnecessary additional event loops

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f67eccedd9836e6ced1f57ae9889f57a5400a3d7
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

f67ecce by Tomasz Moń (desowin@xxxxxxxxx):

    Qt: Do not spin unnecessary additional event loops
    
    Show the dialogs asynchronously so no new event loops are created. This
    not only simplifies stack traces (reduces the nesting level) but also
    prevents hard to debug problems (eg. Bug 15743) from happening.
    
    Change-Id: I85821a1403839a5baca504b40efce0ede2f1e0cb
    Reviewed-on: https://code.wireshark.org/review/34646
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  ef76d65   Fix checks for "do we have an ERSPAN header?"
     add  f67ecce   Qt: Do not spin unnecessary additional event loops


Summary of changes:
 ui/qt/coloring_rules_dialog.cpp          |  35 ++++++---
 ui/qt/coloring_rules_dialog.h            |   1 +
 ui/qt/font_color_preferences_frame.cpp   |  29 +++++---
 ui/qt/font_color_preferences_frame.h     |   1 +
 ui/qt/main_window.cpp                    |   6 +-
 ui/qt/main_window.h                      |   4 ++
 ui/qt/main_window_slots.cpp              | 119 +++++++++++++++++++------------
 ui/qt/module_preferences_scroll_area.cpp |   6 +-
 ui/qt/packet_list.cpp                    |  11 ++-
 ui/qt/protocol_preferences_menu.cpp      |  10 +--
 ui/qt/widgets/capture_filter_edit.cpp    |  12 ++--
 ui/qt/widgets/display_filter_edit.cpp    |  12 ++--
 ui/qt/widgets/field_filter_edit.cpp      |   6 +-
 ui/qt/wireshark_application.h            |   7 +-
 14 files changed, 164 insertions(+), 95 deletions(-)