Wireshark-commits: [Wireshark-commits] master a9fc368: Qt: Move CopyFrom from menu to button
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 26 Aug 2019 06:34:38 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a9fc3681f67628fd112a76b0dc5ec145cc20ef4c
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

a9fc368 by Roland Knall (rknall@xxxxxxxxx):

    Qt: Move CopyFrom from menu to button
    
    Move the CopyFromProfile implementation from a menu to a button
    to ease integration in existing code
    
    Change-Id: I4fb4e952e89665eda99d162e891ac6d3516a6f02
    Reviewed-on: https://code.wireshark.org/review/34266
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    Petri-Dish: Roland Knall <rknall@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  efe2926   NFS: Fix hash table key memory corruption
     add  a9fc368   Qt: Move CopyFrom from menu to button


Summary of changes:
 ui/qt/CMakeLists.txt                               |  4 +-
 ui/qt/coloring_rules_dialog.cpp                    | 14 ++---
 ui/qt/coloring_rules_dialog.h                      |  2 +-
 ui/qt/io_graph_dialog.cpp                          | 14 ++---
 ui/qt/io_graph_dialog.h                            |  2 +-
 ui/qt/uat_dialog.cpp                               | 15 ++---
 ui/qt/uat_dialog.h                                 |  2 +-
 ui/qt/uat_frame.cpp                                | 12 ++--
 ui/qt/uat_frame.h                                  |  2 +-
 ui/qt/uat_frame.ui                                 |  7 ++-
 ...ofile_menu.cpp => copy_from_profile_button.cpp} | 71 ++++++++++++++++------
 ui/qt/widgets/copy_from_profile_button.h           | 43 +++++++++++++
 ui/qt/widgets/copy_from_profile_menu.h             | 35 -----------
 13 files changed, 126 insertions(+), 97 deletions(-)
 rename ui/qt/widgets/{copy_from_profile_menu.cpp => copy_from_profile_button.cpp} (58%)
 create mode 100644 ui/qt/widgets/copy_from_profile_button.h
 delete mode 100644 ui/qt/widgets/copy_from_profile_menu.h