Wireshark-commits: [Wireshark-commits] master 2a32808: Qt: Import zips with illegal names
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 13 Aug 2019 08:16:57 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2a32808e50a1c0f558a3553cd141b1dd8d217eb9
Submitter: "Roland Knall <rknall@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

2a32808 by Roland Knall (rknall@xxxxxxxxx):

    Qt: Import zips with illegal names
    
    If a profile import contains illegal path names inside the zip
    container, the illegal names are being filtered out and replaced with an
    underscore
    
    Change-Id: I4e1bc495156b8c1cd3f4dfca69604e880647f74e
    Reviewed-on: https://code.wireshark.org/review/34220
    Petri-Dish: Roland Knall <rknall@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  9ac6195   Qt: Correctly identify the active profile
     add  2a32808   Qt: Import zips with illegal names


Summary of changes:
 ui/qt/models/profile_model.cpp       | 28 ++++++++++----
 ui/qt/models/profile_model.h         |  4 ++
 ui/qt/utils/wireshark_zip_helper.cpp | 73 +++++++++++++++++++++++++++---------
 ui/qt/utils/wireshark_zip_helper.h   |  2 +-
 4 files changed, 81 insertions(+), 26 deletions(-)