Wireshark-commits: [Wireshark-commits] master 1aaf590: EAP: ignore retransmissions to avoid breakin
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 13 Aug 2019 07:50:56 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1aaf590facc09ee710bd126c32c4972ff0c1a5e9
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

1aaf590 by Peter Wu (peter@xxxxxxxxxxxxx):

    EAP: ignore retransmissions to avoid breaking EAP-TTLS reassembly
    
    Remember the most recently seen Identifier field for the authenticator
    and peer. Flag packets that mismatch and skip further processing if it
    could modify the state as is the case for EAP-TTLS.
    
    Bug: 5056
    Change-Id: If439d5ef2ae390208f678ff271d3036efaf9fa7f
    Reviewed-on: https://code.wireshark.org/review/34261
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  1d40491   Diameter 3GPP: Dissect new ULR and DSR Flags.
     add  1aaf590   EAP: ignore retransmissions to avoid breaking EAP-TTLS reassembly


Summary of changes:
 epan/dissectors/packet-eap.c | 50 +++++++++++++++++++++++++++++++++++++++-----
 1 file changed, 45 insertions(+), 5 deletions(-)