Wireshark-commits: [Wireshark-commits] master-3.0 f5fccad: Qt: fix wrong default packet list order
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 11 Aug 2019 16:03:44 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f5fccadb0f9d8517447e023fa7cc6383d1405faa
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

f5fccad by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: fix wrong default packet list order in Qt 5.13
    
    Workaround a Qt 5.13 bug that made QTreeView::sortByColumn(-1)
    ineffective and results in sorting rows by the first column in reverse
    order.
    
    This must be called before setModel since that already triggers sorting.
    
    Bug: 15979
    Change-Id: I86c26959d3cb9dd4118193dcda4b1308cc911290
    Reviewed-on: https://code.wireshark.org/review/34226
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    (cherry picked from commit e1e41c0db5538c58bcbe907cb8020ea89c830fc7)
    Reviewed-on: https://code.wireshark.org/review/34232
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  8fd4d82   Qt: fix more more Qt 5.13 deprecation warnings
     add  f5fccad   Qt: fix wrong default packet list order in Qt 5.13


Summary of changes:
 ui/qt/packet_list.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)