Wireshark-commits: [Wireshark-commits] master a4c95bc: TDS: Fix handling of numeric and decimal typ
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 04 Aug 2019 05:32:48 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a4c95bcddf8474d36950f1d1b26e64b431bec5c3
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

a4c95bc by Craig Jackson (cejackson51@xxxxxxxxx):

    TDS: Fix handling of numeric and decimal types.
    
    Microsoft and Sybase introduced big-integer types separately and incompatibly.
    The existing code doesn't completely handle either of them.
    This should fix both implementations.
    
    Bug: 15803
    Change-Id: I23dda7790185581716141a5a7556c3858b0ecb93
    Reviewed-on: https://code.wireshark.org/review/34114
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  e206eb2   Use ENC_NA, not ENC_BIG_ENDIAN, for a sequence of bytes.
     add  a4c95bc   TDS: Fix handling of numeric and decimal types.


Summary of changes:
 epan/dissectors/packet-tds.c | 103 +++++++++++++++++++++++++++++++------------
 1 file changed, 76 insertions(+), 27 deletions(-)