Wireshark-commits: [Wireshark-commits] master ade3a6b: Set tm_isdst before calling mktime().
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 04 Aug 2019 01:38:47 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ade3a6b658dd32a818a935d43c41407c22612834
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

ade3a6b by Guy Harris (guy@xxxxxxxxxxxx):

    Set tm_isdst before calling mktime().
    
    You either have to set it to 1 or 0 if you know whether it's shifted
    time or set it to -1 if you don't.
    
    Should address Coverity CID 1452227.
    
    Change-Id: I7d435bb6b7dd8897b44bf5103578e3db1a30379e
    Reviewed-on: https://code.wireshark.org/review/34175
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  8ae710d   Note the Microsoft standard, fix the LZNT1 comment.
     add  ade3a6b   Set tm_isdst before calling mktime().


Summary of changes:
 wiretap/busmaster.c | 26 ++++++++++++++------------
 1 file changed, 14 insertions(+), 12 deletions(-)