Wireshark-commits: [Wireshark-commits] master edd5eaa5: Don't format printable non-ASCII Unicode ch
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 25 Jul 2019 14:50:49 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=edd5eaa57e4eb9157d7593dff6a58e030bf8987e
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

edd5eaa5 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't format printable non-ASCII Unicode characters as escape sequences.
    
    Note that even strings fetched with ENC_ASCII may contain them - bytes
    with the 8th bit set get mapped to REPLACEMENT CHARACTER.
    
    This means we can format STR_UNICODE fields with format_text(); do so.
    
    Bug: 1372
    Change-Id: Ia32c3a92d220ac5174ecd25f33e2d1f85cfb8cb8
    Reviewed-on: https://code.wireshark.org/review/34080
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  dd5f2bd   USBLL: Verify DATA packets CRC-16
     add  edd5eaa5  Don't format printable non-ASCII Unicode characters as escape sequences.


Summary of changes:
 epan/proto.c   |   3 +-
 epan/strutil.c | 742 +++++++++++++++++++++++++++++++++++++++++++++------------
 2 files changed, 590 insertions(+), 155 deletions(-)