Wireshark-commits: [Wireshark-commits] master 22e74ec: tvb_lz77huff: reduce stack memory usage
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 16 Jul 2019 21:43:02 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=22e74ec018ffd42fd02c68bc3587a53362efe078
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

22e74ec by Aurelien Aptel (aaptel@xxxxxxxx):

    tvb_lz77huff: reduce stack memory usage
    
    clang errs about the stack frame size being too big.
    
    * use indexes instead of pointers
    * use guint8 instead of gboolean (== int)
    * remplace hard coded 512 with #define
    
    Change-Id: Idae70677f20e88ac8bba93899573e0137b9a3d7e
    Fixes: 0db39ae59a ("smb2: add support for decompression")
    Reviewed-on: https://code.wireshark.org/review/33965
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  6a7b012   Don't just grab raw string data with tvb_memcpy().
     add  22e74ec   tvb_lz77huff: reduce stack memory usage


Summary of changes:
 epan/tvbuff_lz77huff.c | 34 +++++++++++++++++++---------------
 1 file changed, 19 insertions(+), 15 deletions(-)