Wireshark · Wireshark-commits: [Wireshark-commits] master-2.6 9424c89: Qt: Check for NULL pointer in profile->reference

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9424c8963692a218b555fb4a6454535658671ca2
Submitter: "Stig Bjørlykke <stig@xxxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

9424c89 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Qt: Check for NULL pointer in profile->reference
    
    Check for NULL pointer before using profile->reference in strcmp()
    because this will give a crash. Doing a copy profile from a new profile
    will set the reference to NULL in get_profile_parent().
    
    Use an unambiguously profile reference value NULL as profile->reference
    when creating a new profile to align with when copy from a new profile.
    
    Change-Id: Id61d5138ac8723e7c7ebad4d2252cf659c7569d4
    Reviewed-on: https://code.wireshark.org/review/33937
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    (cherry picked from commit 5ad368fd1888963a1714d1ad36ab09219feaa926)
    Reviewed-on: https://code.wireshark.org/review/33953
    

Actions performed:

    from  8088747   Clean up indentation.
     add  9424c89   Qt: Check for NULL pointer in profile->reference


Summary of changes:
 ui/qt/profile_dialog.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)