Wireshark-commits: [Wireshark-commits] master 7d603e3: smb2: add support for AES-128-GCM decryption
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 02 Jul 2019 17:54:10 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7d603e344cb78b43b5c51af32f17b4c0e6921906
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

7d603e3 by Aurelien Aptel (aaptel@xxxxxxxx):

    smb2: add support for AES-128-GCM decryption
    
    epan/dissectors/packet-smb2.c:
    
    - factor out decryption code from transform header dissector
    - rewrite CCM decryption to use the proper gcrypt cipher
    - add GCM support
    - change weird 1 element CCM bitmask to value_string
    
    test/suite_decryption.py: add smb2 GCM decryption test
    
    - add one test
    - add a new capture to test smb3.1.1 AES-128-GCM decryption
    
    Change-Id: Id5ab75e1830bc24ace9f9b2f2dbd5a3c20666d52
    Reviewed-on: https://code.wireshark.org/review/33600
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  0368b77   imap: move the more general field first.
     add  7d603e3   smb2: add support for AES-128-GCM decryption


Summary of changes:
 epan/dissectors/packet-smb2.c            | 214 ++++++++++++++++++++-----------
 epan/dissectors/packet-smb2.h            |   1 +
 test/captures/smb311-aes-128-gcm.pcap.gz | Bin 0 -> 1380 bytes
 test/suite_decryption.py                 |  14 ++
 4 files changed, 157 insertions(+), 72 deletions(-)
 create mode 100644 test/captures/smb311-aes-128-gcm.pcap.gz