Wireshark-commits: [Wireshark-commits] master 15cae46: ui: Refactoring column_prefs_add_custom
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 30 Jun 2019 13:08:48 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=15cae4650f711a6658480671e4f2d1fe891a1e43
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

15cae46 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    ui: Refactoring column_prefs_add_custom
    
    Unify column_prefs_add_custom() and column_prefs_add_custom_with_position()
    because the former is unused in the current implementation.
    
    Remove the unused custom_occurrence parameter.
    
    Change-Id: Ib018b9dc614674fc175810827ef789ef469059eb
    Reviewed-on: https://code.wireshark.org/review/33760
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  a854811   Qt: fix more more Qt 5.13 deprecation warnings
     add  15cae46   ui: Refactoring column_prefs_add_custom


Summary of changes:
 ui/preference_utils.c       | 10 ++--------
 ui/preference_utils.h       | 20 ++------------------
 ui/qt/main_window_slots.cpp |  2 +-
 3 files changed, 5 insertions(+), 27 deletions(-)