Wireshark-commits: [Wireshark-commits] master e536a1b: Make get_unicode_or_ascii_string() static.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 14 Jun 2019 06:27:07 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e536a1b113a4349ccb18e6dfe88d5d7954d1a415
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

e536a1b by Guy Harris (guy@xxxxxxxxxxxx):

    Make get_unicode_or_ascii_string() static.
    
    It shouldn't be used by anything outside packet-smb.c; the standard
    string-encoding mechanisms should be used for UTF-16 strings.
    
    Change-Id: Ibfc8f5c460c5aef85a5a2a3ee39a066fd9501b16
    Reviewed-on: https://code.wireshark.org/review/33592
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  2d795b1   The second byte of NT_Trans_Parameters is no longer a reserved byte.
     add  e536a1b   Make get_unicode_or_ascii_string() static.


Summary of changes:
 epan/dissectors/packet-smb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)