Wireshark-commits: [Wireshark-commits] master 9239ce6: Don't check lenretval in proto_tree_add_item
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 12 Jun 2019 22:19:46 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9239ce6900676868731a3057e974d8fc610eca78
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

9239ce6 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't check lenretval in proto_tree_add_item_ret_display_string_and_length().
    
    It can't be null, and it must never be passed a null pointer.
    
    Fixes Coverity CID 1445961.
    
    Change-Id: Ifad962c51e23706fdc544326a45543fe11b73fd1
    Reviewed-on: https://code.wireshark.org/review/33572
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  1000f3f   Don't assume dissect_smb2_olb_string() returned a non-null pointer.
     add  9239ce6   Don't check lenretval in proto_tree_add_item_ret_display_string_and_length().


Summary of changes:
 epan/proto.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)