Wireshark-commits: [Wireshark-commits] master f5bc4f9: batadv: Fix info column seqno of ICMP v15 pa
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 10 Jun 2019 21:00:46 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f5bc4f91e251caa51481c91895cb07bb535ad9e5
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

f5bc4f9 by Sven Eckelmann (sven@xxxxxxxxxxxxx):

    batadv: Fix info column seqno of ICMP v15 packets
    
    The sequence number shown in the info field is read from the
    icmp_packet_v15 object before the actual member is actual read from the
    packet buffer. Just split the initialization of the info column to the
    actual dissection code for the packet to avoid these kind of problems.
    
    Change-Id: I2ab316527854260bb8f85d2283964426fb7508bd
    Fixes: 4cc431579363 ("batadv: Add dissector support for batadv v15")
    Signed-off-by: Sven Eckelmann <sven@xxxxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/33546
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  ee2da42   batadv: Fix offset to ICMP v15 message type
     add  f5bc4f9   batadv: Fix info column seqno of ICMP v15 packets


Summary of changes:
 epan/dissectors/packet-batadv.c | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)