Wireshark-commits: [Wireshark-commits] master 237ec13: IP: Make dissection of ip.frag_offset RFC 79
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 30 May 2019 21:47:26 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=237ec1349f869b4a03282168b5c99d1bcce286ac
Submitter: "Sake Blok <sake.blok@xxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

237ec13 by Sake Blok (sake@xxxxxxxxxx):

    IP: Make dissection of ip.frag_offset RFC 791 compliant
    
    The v2.5.0rc0-478-g558fe23226, the dissection of ip.frag_offset changed
    to be listed under "Flags", this is not correct. The Fragmentation
    Offset is a separate field according to the RFC. This change corrects
    that behavior. Also, the raw value from the header was shown instead of
    the real byte offset, this is also corrected.
    
    Change-Id: I1d6dfc4314091eb6f3eef418c5a17ed37f7a1200
    Fixes: v2.5.0rc0-478-g558fe23226 ("[IP] Simplify paring of flags field by using proto_tree_add_bitmask_with_flags().")
    Reviewed-on: https://code.wireshark.org/review/33422
    Petri-Dish: Sake Blok <sake.blok@xxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Sake Blok <sake.blok@xxxxxxxxxx>
    

Actions performed:

    from  49b6523   btle: Correctly detect l2cap fragment start
     add  237ec13   IP: Make dissection of ip.frag_offset RFC 791 compliant


Summary of changes:
 epan/dissectors/packet-ip.c |  5 ++--
 test/baseline/dhcp.ek       |  2 +-
 test/baseline/dhcp.json     | 16 ++++++-------
 test/baseline/dhcp.jsonraw  | 56 ++++++++++++++++++++++-----------------------
 4 files changed, 40 insertions(+), 39 deletions(-)