Wireshark-commits: [Wireshark-commits] master-2.4 f0d43d3: Fix handling of headers in body part.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 29 May 2019 18:08:32 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f0d43d3138f438422496b638f42fa026a3b68fe3
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.4
Repository: wireshark

Commits:

f0d43d3 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix handling of headers in body part.
    
    Check whether the unfolded-and-compacted header has only printable
    characters, not whether the full header does - the full header may
    include LWSP, which includes HT, CR, and LF, none of which are
    considered "printable", so valid headers were being treated as not being
    headers, causing mis-dissection of some packets.
    
    We don't need to split the header name from the value -
    is_known_multipart_header() stops comparison at the end of the header
    name.
    
    Change-Id: I96e4ac0b69df726b984ee7faeea19eda18be223c
    Reviewed-on: https://code.wireshark.org/review/33417
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    (cherry picked from commit 78a106dc2a5516b9b9cf42cf973d990828cac54e)
    Reviewed-on: https://code.wireshark.org/review/33420
    

Actions performed:

    from  d914117   Clean up indentation.
     add  f0d43d3   Fix handling of headers in body part.


Summary of changes:
 epan/dissectors/packet-multipart.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)