Wireshark-commits: [Wireshark-commits] master-3.0 251b115: Dissect LDAP strings as UTF-8.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 28 May 2019 07:30:56 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=251b115a81090bb5d7691659413106aaf2f76b19
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

251b115 by Guy Harris (guy@xxxxxxxxxxxx):

    Dissect LDAP strings as UTF-8.
    
    This requires some special hackery, including a new packet-ber.c
    routine, as those strings are just OCTET STRINGs, not UTF8Strings.
    
    Change-Id: I776ed47f7400eba366a630b60b94be3397f7b45f
    Reviewed-on: https://code.wireshark.org/review/33403
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (backported from commit f72e504817de983039f785439036d57897465d99)
    Reviewed-on: https://code.wireshark.org/review/33404
    

Actions performed:

    from  ce41aa1   Fix for incorrectly decoded RSL ERR REP/BCCH INFORMATION optional IEs
     add  251b115   Dissect LDAP strings as UTF-8.


Summary of changes:
 debian/libwireshark12.symbols                    |   1 +
 epan/dissectors/asn1/ldap/ldap.cnf               |   7 +-
 epan/dissectors/asn1/ldap/packet-ldap-template.c |   2 +-
 epan/dissectors/packet-ber.c                     | 139 +++++++++++++----------
 epan/dissectors/packet-ber.h                     |   1 +
 epan/dissectors/packet-ldap.c                    | 121 ++++++++++----------
 6 files changed, 143 insertions(+), 128 deletions(-)