Wireshark-commits: [Wireshark-commits] master daead4e: dhcp: fix used-but-marked-unused warnings
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 26 May 2019 19:04:57 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=daead4e5fcc3586bb45a4eb8a2bc31dd3de7b2af
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

daead4e by Martin Kaiser (wireshark@xxxxxxxxx):

    dhcp: fix used-but-marked-unused warnings
    
    dhcp.c:3087:26: error: 'pinfo' was marked unused but was used
                    expert_add_info_format(pinfo, tree, &ei_dhcp_bad_length, "length must be >= 10");
                                           ^
    dhcp.c:3119:26: error: 'pinfo' was marked unused but was used
                    expert_add_info_format(pinfo, tree, &ei_dhcp_bad_length, "length must be 4");
                                           ^
    dhcp.c:3131:26: error: 'pinfo' was marked unused but was used
                    expert_add_info_format(pinfo, tree, &ei_dhcp_bad_length, "length must be 4");
                                           ^
    dhcp.c:3143:26: error: 'pinfo' was marked unused but was used
                    expert_add_info_format(pinfo, tree, &ei_dhcp_bad_length, "length must be 4");
                                           ^
    dhcp.c:3155:26: error: 'pinfo' was marked unused but was used
                    expert_add_info_format(pinfo, tree, &ei_dhcp_bad_length, "length must >= 1");
                                           ^
    dhcp.c:3176:26: error: 'pinfo' was marked unused but was used
                    expert_add_info_format(pinfo, tree, &ei_dhcp_bad_length, "length must >= 5");
                                           ^
    dhcp.c:3201:26: error: 'pinfo' was marked unused but was used
                    expert_add_info_format(pinfo, tree, &ei_dhcp_bad_length, "length must be 4");
    
    Change-Id: If4e05284a4489e7cea75fee52733851533dacbc1
    Reviewed-on: https://code.wireshark.org/review/33372
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    Petri-Dish: Martin Kaiser <wireshark@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  72cd130   dot11decrypt: fix a used-but-marked-unused warning
     add  daead4e   dhcp: fix used-but-marked-unused warnings


Summary of changes:
 epan/dissectors/packet-dhcp.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)