Wireshark-commits: [Wireshark-commits] master e08937a: rbm: fix a bunch of used-but-marked-unused w
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 26 May 2019 19:04:15 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e08937ac4466abbe9d6f883fb22134cb2cd364a9
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

e08937a by Martin Kaiser (wireshark@xxxxxxxxx):

    rbm: fix a bunch of used-but-marked-unused warnings
    
    file-rbm.c:143:34: error: 'tree' was marked unused but was used
            proto_tree_add_int_format_value(tree, hf_rbm_integer, tvb, *offset, len, value, "%d", value);
                                            ^
    file-rbm.c:374:23: error: 'offset' was marked unused but was used
            gint offset_start = *offset;
                                 ^
    file-rbm.c:375:48: error: 'tree' was marked unused but was used
            proto_tree* drb_tree = proto_tree_add_subtree(tree, tvb, *offset, 0, ett_variable, NULL, "Objects");
                                                          ^
    file-rbm.c:375:54: error: 'tvb' was marked unused but was used
            proto_tree* drb_tree = proto_tree_add_subtree(tree, tvb, *offset, 0, ett_variable, NULL, "Objects");
                                                                ^
    file-rbm.c:375:60: error: 'offset' was marked unused but was used
            proto_tree* drb_tree = proto_tree_add_subtree(tree, tvb, *offset, 0, ett_variable, NULL, "Objects");
                                                                      ^
    file-rbm.c:376:21: error: 'tvb' was marked unused but was used
            dissect_rbm_object(tvb, pinfo, drb_tree, offset, NULL, NULL);
                               ^
    file-rbm.c:376:26: error: 'pinfo' was marked unused but was used
            dissect_rbm_object(tvb, pinfo, drb_tree, offset, NULL, NULL);
                                    ^
    file-rbm.c:376:43: error: 'offset' was marked unused but was used
            dissect_rbm_object(tvb, pinfo, drb_tree, offset, NULL, NULL);
                                                     ^
    file-rbm.c:377:21: error: 'tvb' was marked unused but was used
            dissect_rbm_object(tvb, pinfo, drb_tree, offset, NULL, NULL);
                               ^
    file-rbm.c:377:26: error: 'pinfo' was marked unused but was used
            dissect_rbm_object(tvb, pinfo, drb_tree, offset, NULL, NULL);
                                    ^
    file-rbm.c:377:43: error: 'offset' was marked unused but was used
            dissect_rbm_object(tvb, pinfo, drb_tree, offset, NULL, NULL);
                                                     ^
    file-rbm.c:378:32: error: 'offset' was marked unused but was used
            proto_item_set_len(drb_tree, *offset - offset_start);
                                          ^
    file-rbm.c:526:26: error: 'pinfo' was marked unused but was used
                    expert_add_info_format(pinfo, tree, &ei_rbm_version_unsupported, "Version %u.%u is not supported (only %u.%u)",
    
    Change-Id: Id255df237c43c313720797a46c0e877f0f7550e0
    Reviewed-on: https://code.wireshark.org/review/33370
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    Petri-Dish: Martin Kaiser <wireshark@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  01768d0   rfc7468: fix a used-but-marked-unused warning
     add  e08937a   rbm: fix a bunch of used-but-marked-unused warnings


Summary of changes:
 epan/dissectors/file-rbm.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)