Wireshark-commits: [Wireshark-commits] master 8494ef9: AERON: Properly handle heartbeat frame lengt
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 25 May 2019 13:28:13 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8494ef903a6cbdbebeacfa03a73320ced09cfded
Submitter: "Martin Kaiser <wireshark@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

8494ef9 by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    AERON: Properly handle heartbeat frame length
    
    The aeron hartbeat frame is a data frame with zero length. The rounded
    length is used to report back consumed bytes. Set that to the real
    length of a heartbeat frame, being 24.
    
    Sample captures show trailing zero bytes after a heartbeat frame. Make
    sure trailing zero bytes are not tested for additional frames.
    
    CID 1439592
    
    Change-Id: I99580179830b6de0886a1d57f994f4a9c5a1ae6d
    Reviewed-on: https://code.wireshark.org/review/33243
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    

Actions performed:

    from  3ec7824   iso14443: (trivial) i_block_frag_items is used
     add  8494ef9   AERON: Properly handle heartbeat frame length


Summary of changes:
 epan/dissectors/packet-aeron.c | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)