Wireshark-commits: [Wireshark-commits] master dd4c987: CMake+macOS: Use symlinks for our CLI utilit
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 24 May 2019 17:05:45 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dd4c9877560774c9f07c454028027539a562fe1a
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

dd4c987 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    CMake+macOS: Use symlinks for our CLI utilities.
    
    On macOS, <build directory>/run/wireshark is a wrapper script that execs
    run/Wireshark.app/Contents/MacOS/Wireshark so that Launch Services will
    activate our application properly. We don't need to worry about this for
    our other executables. Make them symlinks so that we can run things like
    `lldb run/tshark` with impunity.
    
    Change-Id: I4e656d778040ece722f873b1a7f6e6e60d21e2a6
    Reviewed-on: https://code.wireshark.org/review/33071
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  29283de   Qt: unchecked dynamic cast
     add  dd4c987   CMake+macOS: Use symlinks for our CLI utilities.


Summary of changes:
 CMakeLists.txt        | 20 +++++++++++++-------
 extcap/CMakeLists.txt | 15 ++++++++-------
 2 files changed, 21 insertions(+), 14 deletions(-)