Wireshark-commits: [Wireshark-commits] master f194695: gprscdr: update RatingGroupId as unsigned
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 24 May 2019 11:00:29 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f1946955ca61e2c05368b196d0c28356e8cb7aee
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

f194695 by Joakim Karlsson (oakimk@xxxxxxxxx):

    gprscdr: update RatingGroupId as unsigned
    
    Changed type for the RatingGroupId fields, from signed32 to unsigned32.
    This fixes the problem of getting "-1" values at G_MAXUINT32.
    
    Change-Id: Ia1113901657bedc8d9c231aa1fe38b63170b2257
    Reviewed-on: https://code.wireshark.org/review/33338
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  0e498d4   Add support decode extremeNetworks-avaya access point TLVs
     add  f194695   gprscdr: update RatingGroupId as unsigned


Summary of changes:
 epan/dissectors/asn1/gprscdr/gprscdr.cnf | 1 +
 epan/dissectors/packet-gprscdr.c         | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)