Wireshark-commits: [Wireshark-commits] master 6cb990c: DPNSS: dissect Service Indicator Code synch/
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 23 May 2019 04:12:38 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6cb990ccb03e3fa4154e080d8592f64ca45a9c7b
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

6cb990c by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    DPNSS: dissect Service Indicator Code synch/asynch info
    
    The DPNSS specification for the Service Indicator Code
    Synch/Asynchronous Information field states that the lower three bits of
    this field define the Data Type. This requires a filter of three bits,
    in this case 0x7, instead of 0x3 which is two bits.
    
    CID 1159107
    
    Change-Id: I38eec252c771adf085f98c3be077c9de102a37d2
    Reviewed-on: https://code.wireshark.org/review/33317
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  37775b1   USB: Add expert info for unknown URBs captured by USBPcap
     add  6cb990c   DPNSS: dissect Service Indicator Code synch/asynch info


Summary of changes:
 epan/dissectors/packet-dpnss.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)