Wireshark · Wireshark-commits: [Wireshark-commits] master 37775b1: USB: Add expert info for unknown URBs captured by USBPcap

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=37775b10b8a95fee524a84cad0204adf387335c0
Submitter: "Pascal Quantin <pascal@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

37775b1 by Tomasz Moń (desowin@xxxxxxxxx):

    USB: Add expert info for unknown URBs captured by USBPcap
    
    Current development builds and next official release of USBPcap will
    feature generic unknown URB Function capture. When USBPcap notices URB
    Function code that it does not understand, it'll write the USBPcap
    pseudoheader with transfer type 0xFF (URB_UNKNOWN). The pseudoheader
    will contain the IRP ID, status code, URB Function code, bus id, device
    address and PDO->FDO or FDO->PDO flag. Other fields in the pseudoheader
    will be 0.
    
    Capturing such packets serves multiple purposes:
      * Makes it clear that the USBPcap capture is incomplete
      * Combined with expert info, makes casual users able to report device
        whose driver does issue IRPs with unhandled URB Function codes
      * Shows that USBPcap can be improved to capture such data
    
    Bug: 15792
    Change-Id: Ib44c6bf05dd9f025617368e44b7dc80b5910aacd
    Reviewed-on: https://code.wireshark.org/review/33307
    Petri-Dish: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    

Actions performed:

    from  be9bdfd   Add dissection recursion checks.
     add  37775b1   USB: Add expert info for unknown URBs captured by USBPcap


Summary of changes:
 epan/dissectors/packet-usb.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)