Wireshark · Wireshark-commits: [Wireshark-commits] master c4f0b50: Qt: Do not leak C run-time handles on Windows

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c4f0b500eb5ae4c53bd668809d0b36e71d141c35
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

c4f0b50 by Tomasz Moń (desowin@xxxxxxxxx):

    Qt: Do not leak C run-time handles on Windows
    
    The _open_osfhandle() does take ownership of the handle and thus the
    underlying handle gets closed at the same time as the file-descriptor.
    As we want to preserve the underlying pipe handle, create a duplicate
    handle and use the duplicate handle with _open_osfhandle().
    
    Change-Id: Iaa52fbae8e72b1ba74ab8ea9a44def8dc2ab4570
    Reviewed-on: https://code.wireshark.org/review/33251
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  41813ba   BTMESH: fix unused compile error without/older GCrypt
     add  c4f0b50   Qt: Do not leak C run-time handles on Windows


Summary of changes:
 ui/qt/interface_toolbar.cpp | 24 +++++++++++++++++++++---
 1 file changed, 21 insertions(+), 3 deletions(-)