Wireshark-commits: [Wireshark-commits] master-3.0 9f640b5: SCTP: assure size before attempting chec
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 21 May 2019 11:01:54 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9f640b5037a88e9cfca8997c626a02430a0b5c34
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

9f640b5 by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    SCTP: assure size before attempting checksum calculation
    
    When checksum calculations are performed (irrespective of type) the
    calculation is assumed to be possible on at least a common header and
    optionally a payload. This assumption was not checked, which could
    lead to out of bound access of packet buffer data.
    Simply adding the assurance that enough buffer data is available avoids
    this out of bound access.
    
    CID 1439698
    
    Change-Id: I5fec69b96b1064ffdda11f51b882fe5775844475
    Reviewed-on: https://code.wireshark.org/review/33185
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit 1573d4ddb2d0ff4dfa5b41f91f5620f1c7dd475f)
    Reviewed-on: https://code.wireshark.org/review/33286
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    

Actions performed:

    from  bfd3bb2   pcapng: fix the magic when bytes are swapped.
     add  9f640b5   SCTP: assure size before attempting checksum calculation


Summary of changes:
 epan/dissectors/packet-sctp.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)