Wireshark-commits: [Wireshark-commits] master e803f83: extcap: Fix memory leak in extcap_has_toolba
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 20 May 2019 13:19:45 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e803f83ac8f6f55247ce99a57bbfa8633019e4d7
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

e803f83 by Tomasz Moń (desowin@xxxxxxxxx):

    extcap: Fix memory leak in extcap_has_toolbar()
    
    The content of the list returned by g_hash_table_get_values() is owned by
    GHashTable and should not be modified or freed. However, the list itself
    should be freed using g_list_free().
    
    Use g_strcmp0() to compare keys instead of strcmp() as it handles NULL
    gracefully.
    
    Change-Id: I8f5d70ffc2cd6eb5001b5086e4e31256b65431c7
    Reviewed-on: https://code.wireshark.org/review/33246
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  5689136   fix typo: supres... -> suppres...
     add  e803f83   extcap: Fix memory leak in extcap_has_toolbar()


Summary of changes:
 extcap.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)