Wireshark-commits: [Wireshark-commits] master 640ded8: Fix some signedness warnings.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 17 May 2019 17:00:15 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=640ded8e1d45ec3ee8594c385b1045cbaa0042a0
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

640ded8 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix some signedness warnings.
    
    Packet data is raw octets, meaning guint8s, not chars or gchars.
    
    The last argument to recvfrom should be of type socklen_t on UN*X and
    int on Windows; wsutil/socket.h defines socklen_t to be int on Windows,
    so just use socklen_t.
    
    Change-Id: I5355a246e0f74f39c0f8e198d8dd9769b623af49
    Reviewed-on: https://code.wireshark.org/review/33242
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  075fc13   3gpp_32_423: Fix dissection of changeTime.
     add  640ded8   Fix some signedness warnings.


Summary of changes:
 extcap/ciscodump.c |  6 +++---
 extcap/udpdump.c   | 18 +++++++++---------
 2 files changed, 12 insertions(+), 12 deletions(-)