Wireshark-commits: [Wireshark-commits] master 038470b: Clean up some signed vs. unsigned warnings.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=038470b597449df622d628db389b0669b4f8c70b
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark
Commits:
038470b by Guy Harris (guy@xxxxxxxxxxxx):
Clean up some signed vs. unsigned warnings.
Octet arrays are octets of guint8s, not gchars/chars.
Make some strings arrays of chars/gchars, not guint8s; this needs more
thought (throughout Wireshark).
Offsets into tvbuffs are signed, not unsigned. (This is to support
negative offsets, which are offsets from the end of the tvbuff. We
might want to remove that and go with unsigned offsets, and have the
few, if any, places where that feature is used explicitly calculate the
offset from the end based on the tvbuff's length; most if not all of our
handling of trailers/end-of-packet FCSes/etc. does so, and makes sure it
handles the case where the end-of-packet information isn't present, to
better report errors and dissect the stuff before it.)
Change-Id: Ia46ed3fc7c2d8ac97cd14824d521cbc461fb7f45
Reviewed-on: https://code.wireshark.org/review/33239
Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
Actions performed:
from 32a014a Update the warning-suppression statements in idl2wrs.
add 038470b Clean up some signed vs. unsigned warnings.
Summary of changes:
epan/dissectors/packet-gias.c | 6 +--
epan/dissectors/packet-giop.c | 93 ++++++++++++++++++++++--------------------
epan/dissectors/packet-giop.h | 6 +--
epan/dissectors/packet-tango.c | 6 +--
epan/dissectors/packet-ziop.c | 6 +--
tools/wireshark_gen.py | 2 +-
6 files changed, 62 insertions(+), 57 deletions(-)
