Wireshark-commits: [Wireshark-commits] master 3161feb: Integer types are signed, not unsigned.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 16 May 2019 20:18:45 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3161feb02629e243509c889e9a25c095605cb13f
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

3161feb by Guy Harris (guy@xxxxxxxxxxxx):

    Integer types are signed, not unsigned.
    
    (Why does a call to proto_tree_add_item_ret_uint(), passing a a pointer
    to a gint32, rather than a guint32, as the last argument, not cause a
    compiler error?)
    
    Change-Id: Id1a0dfb62694bfe5147f53938bf1c9c8972efb70
    Reviewed-on: https://code.wireshark.org/review/33234
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  1942fa9   Do *NOT* assume col_get_text(cinfo, el) never returns NULL!
     add  3161feb   Integer types are signed, not unsigned.


Summary of changes:
 epan/dissectors/packet-tds.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)