Wireshark-commits: [Wireshark-commits] master 1942fa9: Do *NOT* assume col_get_text(cinfo, el) neve
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 16 May 2019 19:15:47 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1942fa9e5a338bcfb53ee7b77623df0ac8380538
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

1942fa9 by Guy Harris (guy@xxxxxxxxxxxx):

    Do *NOT* assume col_get_text(cinfo, el) never returns NULL!
    
    It can, and, in at least one capture, it does.
    
    Change-Id: Id3540e6551db5d63427f09c6ccc521958ecccac6
    Reviewed-on: https://code.wireshark.org/review/33231
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  576f33f   In pcapng_open(), don't use the local pcapng_t once we know it's a pcapng file.
     add  1942fa9   Do *NOT* assume col_get_text(cinfo, el) never returns NULL!


Summary of changes:
 epan/dissectors/packet-dcm.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)