Wireshark-commits: [Wireshark-commits] master 757ada0: Qt: Fix no interface load preference handlin
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 15 May 2019 21:47:15 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=757ada0e241bc8e6a257cc771e7817dc0a29d997
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

757ada0 by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    Qt: Fix no interface load preference handling
    
    In handling the capture preferences frame, the preference to not load
    interfaces on startup is handled incorrectly. Instead of using the
    preference value itself, the validity of the pointer to the preference is
    used. This leads to some confusing logic.
    Replacing this code with proper preference retrieval.
    This was introduced with commit 7a07832712cc0b533acadec2d627528e624033b6
    
    CID 1439697
    
    Change-Id: I9bf3df413d89f8df55553a7218f34d425eb103de
    Reviewed-on: https://code.wireshark.org/review/33187
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  1573d4d   SCTP: assure size before attempting checksum calculation
     add  757ada0   Qt: Fix no interface load preference handling


Summary of changes:
 ui/qt/capture_preferences_frame.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)