Wireshark-commits: [Wireshark-commits] master 7e8a58e: Explain that not handling byte-swapped pcap
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 14 May 2019 09:21:08 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7e8a58e1e1d429ea2f3f51f1d910ee6e910471bc
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

7e8a58e by Guy Harris (guy@xxxxxxxxxxxx):

    Explain that not handling byte-swapped pcap files breaks the tests.
    
    No, not every machine on which Wireshark is built, run, and tested is
    little-endian.  See bugs 15772 and 15754.
    
    Change-Id: Ice1d012e1a788f6a7bb031bdf0e2f01f523a91ec
    Reviewed-on: https://code.wireshark.org/review/33192
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  3234152   Fix SMB2 decryption on big-endian machines.
     add  7e8a58e   Explain that not handling byte-swapped pcap files breaks the tests.


Summary of changes:
 dumpcap.c | 27 ++++++++++++++++++++++++---
 1 file changed, 24 insertions(+), 3 deletions(-)