Wireshark-commits: [Wireshark-commits] master 87deef6: Clean up some things.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 12 May 2019 21:50:18 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=87deef63c6a7471258b33573717bba885b24527a
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

87deef6 by Guy Harris (guy@xxxxxxxxxxxx):

    Clean up some things.
    
    Have separate expert info items for the PDU length field being too
    short, the PDU length field being too long, a CLV being too short, and a
    CLV being too long.
    
    Do the PDU length checks when we add the PDU length field, and add the
    expert infos to the length item; remember the results of the checks for
    future use.
    
    Use DISSECTOR_ASSERT for the tests in osi_check_and_get_checksum() that
    make sure the checksum field is contained within the data to be
    checksummed, so that's reported as a dissector bug to the user.
    
    That means that osi_check_and_get_checksum() only returns FALSE if we
    don't have all the data available to checksum; that already gets
    reported as an indication that the checksum is unverified, so we don't
    need to put confusing and misleading expert infos about the PDU
    length - whatever PDU length errors need to be reported have already
    been reported, as per the above.
    
    Make expert info names more consistent, and fix one expert info variable
    name.
    
    Make the length argument to isis_dissect_clvs() unsigned.
    
    Clean up white space.
    
    Change-Id: I0ce799c766dc427602d155c5b48099df8bf51c67
    Reviewed-on: https://code.wireshark.org/review/33179
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  beed21b   Fix the length of the item added for the value field of undissected CLVs.
     add  87deef6   Clean up some things.


Summary of changes:
 epan/dissectors/packet-isis-clv.c   |   4 +-
 epan/dissectors/packet-isis-clv.h   |   2 +-
 epan/dissectors/packet-isis-hello.c |  74 ++++++++++++----------
 epan/dissectors/packet-isis-lsp.c   | 120 +++++++++++++++++++-----------------
 epan/dissectors/packet-isis-snp.c   |  87 ++++++++++++++------------
 epan/dissectors/packet-osi.c        |  14 +++--
 6 files changed, 166 insertions(+), 135 deletions(-)