Wireshark · Wireshark-commits: [Wireshark-commits] master 9f8ac4d: IEEE 802.15.4: Separate ACK tracking and conversations

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9f8ac4d422ba8262ef52b203f08aa779e54fb9ca
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

9f8ac4d by Kenneth Soerensen (knnthsrnsn@xxxxxxxxx):

    IEEE 802.15.4: Separate ACK tracking and conversations
    
    ACK tracking did not work for protocols like ZigBee because the ACK is
    send without address information. By moving the ACK tracking out-side
    the conversation and only use the interface and the sequence number to
    match requests and ACKs this is now working.
    
    If addresses are present in the ACK they will still be used to avoid
    invalid matches.
    
    The nature of the wmem_tree ensures that the ACK tracking will always
    work on the latest requests.
    
    Change-Id: I5c763e34ec340b19a7998ddcfe9f72fccfd2acd1
    Reviewed-on: https://code.wireshark.org/review/32927
    Reviewed-by: James Ko <jck@xxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  550e033   Flexray: put the flexray_identifier structure into a header
     add  9f8ac4d   IEEE 802.15.4: Separate ACK tracking and conversations


Summary of changes:
 epan/dissectors/packet-ieee802154.c | 118 +++++++++++++++++-------------------
 1 file changed, 55 insertions(+), 63 deletions(-)