Wireshark · Wireshark-commits: [Wireshark-commits] master 892914f: Qt: Fix debug assert in Manage Interfaces dialog

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=892914f854d3eec24a3ed34d476fad3fbaf38a87
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

892914f by Tomasz Moń (desowin@xxxxxxxxx):

    Qt: Fix debug assert in Manage Interfaces dialog
    
    ManageInterfacesDialog local view model hierarchy is as follows:
      * InterfaceSortFilterModel
        * InterfaceTreeCacheModel
          * InterfaceTreeModel
    
    Each model should return model indexes associated with itself.
    The InterfaceTreeCacheModel::index() broke the data flow by returning
    model index associated with InterfaceTreeModel. This lead to
    InterfaceSortFilterModel to pass model index associated with
    InterfaceTreeModel to a InterfaceTreeCacheModel instance.
    This resulted in asserts in debug builds.
    
    Fix the problem by returning model index associated with the
    InterfaceTreeCacheModel.
    
    Bug: 13744
    Change-Id: I03a08dbda0bf7cce8f6832e1f34c1a75b8d3cfab
    Reviewed-on: https://code.wireshark.org/review/33014
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  26968f9   Set packet flags for some link layers.
     add  892914f   Qt: Fix debug assert in Manage Interfaces dialog


Summary of changes:
 ui/qt/models/interface_tree_cache_model.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)