Wireshark · Wireshark-commits: [Wireshark-commits] master e111c26: Modbus RTU: Fix Write Single Coil/Register dissection

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e111c26c3e5a8daf564dfbede51da1f848579551
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

e111c26 by Tomasz Moń (desowin@xxxxxxxxx):

    Modbus RTU: Fix Write Single Coil/Register dissection
    
    The normal response to Write Single Coil and Write Single Register is an
    echo of the request and thus the Request/Response of these codes cannot
    be classified based on the length alone.
    
    When the mbrtu.tcp.port value is set to Modbus Slave listening port,
    then the Query/Response is correctly classified as long as the Master
    source port is different to the Slave listening port.
    
    Bug: 15573
    Change-Id: I5cb9f1edb4cdc8e8872196075c14c61ae69b5d15
    Reviewed-on: https://code.wireshark.org/review/33077
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  bff6952   Don't throw an exception when doing the payload type heuristics.
     add  e111c26   Modbus RTU: Fix Write Single Coil/Register dissection


Summary of changes:
 epan/dissectors/packet-mbtcp.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)