Wireshark-commits: [Wireshark-commits] master b078dbc: Do more heuristics to try to identify the Fr
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 06 May 2019 04:36:49 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b078dbc6021df73988aaa6f932f101e73f291bed
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

b078dbc by Guy Harris (guy@xxxxxxxxxxxx):

    Do more heuristics to try to identify the Frame Relay payload.
    
    Try to recognize FRF.3.2/RFC 2427 frames that have a non-UI control field,
    and Ethernet-directly-over-Frame-Relay frames, using heuristics; use a
    heuristic to identify Cisco HDLC-over-Frame-Relay frames.  All
    heuristics involve checking the dissector tables for various protocol
    discriminators (OSI NLPID, Ethernet type, Cisco HDLC type) to see
    whether the value of the purported protocol discriminator has a
    dissector.
    
    Change-Id: I46d6ba2881674b102fb6983a43f0355e036f53d7
    Reviewed-on: https://code.wireshark.org/review/33090
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  a8317ad   S1AP: add ErrorIndication message type to info column
     add  b078dbc   Do more heuristics to try to identify the Frame Relay payload.


Summary of changes:
 epan/dissectors/packet-chdlc.c |  13 ++--
 epan/dissectors/packet-chdlc.h |   3 +-
 epan/dissectors/packet-fr.c    | 150 ++++++++++++++++++++++++++++++++++++-----
 3 files changed, 143 insertions(+), 23 deletions(-)