Wireshark-commits: [Wireshark-commits] master b075b8c: wsutil: Fix 30 seconds freeze if process fai
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 30 Apr 2019 15:51:20 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b075b8c7f7bc88b3d2811ac46c40bd677c5464ee
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

b075b8c by Tomasz Moń (desowin@xxxxxxxxx):

    wsutil: Fix 30 seconds freeze if process fails to start
    
    In ws_pipe_wait_for_pipe() on Windows, the WaitForMultipleObjects() waits
    on the pending pipe connection events and process handle. If the process
    handle is signalled, then it means that the process did exit without
    connecting to the pipes.
    
    The WaitForMultipleObjects() was not waiting on the process handle and thus
    if the process did fail without connecting to pipes the Wireshark gui was
    frozen for 30 seconds.
    
    This change fixes the freeze by increasing the number of handles, so
    WaitForMultipleObjects() is aware of the process handle.
    
    Change-Id: Id13824a60baf4be7795cbe1d5ed1c7932edbff45
    Reviewed-on: https://code.wireshark.org/review/33028
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  15fcf3d   gtpv2: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
     add  b075b8c   wsutil: Fix 30 seconds freeze if process fails to start


Summary of changes:
 wsutil/ws_pipe.c | 1 +
 1 file changed, 1 insertion(+)