Wireshark-commits: [Wireshark-commits] master-2.6 07e9965: Qt: do not fail Conversations -> Follow
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 28 Apr 2019 03:37:39 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=07e9965d5188a4cb9cead4511151f254230d6ce9
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

07e9965 by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: do not fail Conversations -> Follow Stream based on packet list
    
    When a stream index is explicitly given (as is done for items from the
    Conversations statistics dialog), it does not have to query the stream
    index from the packet list. Skip checking the packet list then.
    
    Bug: 15672
    Change-Id: I3f79e6a0997726535c38f9766b894b042ffbf916
    Reviewed-on: https://code.wireshark.org/review/32972
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 8a112f219a2284b6becedfb0bf0970b2ef3f853a)
    Reviewed-on: https://code.wireshark.org/review/33001
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  63fcb64   Do FIND_PACKAGE_HANDLE_STANDARD_ARGS() before checking ZLIB_FOUND.
     add  07e9965   Qt: do not fail Conversations -> Follow Stream based on packet list


Summary of changes:
 ui/qt/follow_stream_dialog.cpp | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)