Wireshark · Wireshark-commits: [Wireshark-commits] master 6e5fade: Qt: Omit calls without values on selector reload

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6e5fade2da230a16f27e6b7a9cc2beecf509c1e6
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

6e5fade by Tomasz Moń (desowin@xxxxxxxxx):

    Qt: Omit calls without values on selector reload
    
    When extcap is started for capture, the argument call is appended to extcap
    commandline if the associated value is not empty or the argument is boolflag.
    
    Unfortunately such rule did not apply when constructing the arguments list
    for selector reload action. This could lead to extcap being called with
    the argument calls without required values (eg. multicheck, selector, string).
    
    This change makes the --extcap-reload-option selector to not contain argument
    calls for which the value is not available.
    
    Bug: 15725
    Change-Id: Ic2456c03b3eb7c7525d19e64ea02afd99ed5f6cb
    Reviewed-on: https://code.wireshark.org/review/32967
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  8bb8d5f   [packet-iec104.c] - Add dissection for IEC 60870-5-101 Messages
     add  6e5fade   Qt: Omit calls without values on selector reload


Summary of changes:
 ui/qt/extcap_options_dialog.cpp | 8 +++++---
 ui/qt/extcap_options_dialog.h   | 2 +-
 2 files changed, 6 insertions(+), 4 deletions(-)