Wireshark-commits: [Wireshark-commits] master 1799b24: FindPCAP: use pkg-config to find pcap depend
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 24 Apr 2019 20:00:45 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1799b24aa397e98f7c894d17b37c087f1ae29d95
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

1799b24 by Fabrice Fontaine (fontaine.fabrice@xxxxxxxxx):

    FindPCAP: use pkg-config to find pcap dependencies
    
    On UNIX, when statically built, pcap can depends on other libraries such
    as -lnl-3. Add a call to pkg-config to find them and append them to
    PCAP_LIBRARIES (and so to CMAKE_REQUIRED_LIBRARIES) otherwise all
    check_function_exists calls will fail
    
    Change-Id: I98361c05553738d015310fae76c17dfc08e131ff
    Ping-Bug: 15713
    Signed-off-by: Fabrice Fontaine <fontaine.fabrice@xxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/32946
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  8f2277c   KNXIP: Prevent possible buffer overrun
     add  1799b24   FindPCAP: use pkg-config to find pcap dependencies


Summary of changes:
 cmake/modules/FindPCAP.cmake | 10 ++++++++++
 1 file changed, 10 insertions(+)