Wireshark-commits: [Wireshark-commits] master-3.0 5408755: KNXIP: Prevent possible buffer overrun
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 24 Apr 2019 08:28:08 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5408755d7e859f05c35963d19bedb962e92b89f7
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

5408755 by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    KNXIP: Prevent possible buffer overrun
    
    When reading the keyring xml file stop reading the name early enough
    not to overrun the name buffer.
    
    Change-Id: Ia98ddcd37b17e9865e24ef53a9146d85af1ae30f
    Reviewed-on: https://code.wireshark.org/review/32954
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit 92abc13fce0234eeca53ea6ea9a99721d0d52977)
    Reviewed-on: https://code.wireshark.org/review/32965
    

Actions performed:

    from  414d8c3   packet: ensure pinfo->curr_layer_num does not depend on tree
     add  5408755   KNXIP: Prevent possible buffer overrun


Summary of changes:
 epan/dissectors/packet-knxip_decrypt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)