Wireshark-commits: [Wireshark-commits] master 900b9f1: CMake: add USE_STATIC option
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 23 Apr 2019 23:19:45 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=900b9f137910c0ad0fe95d7354af8315ffeb0b04
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

900b9f1 by Fabrice Fontaine (fontaine.fabrice@xxxxxxxxx):

    CMake: add USE_STATIC option
    
    USE_STATIC will:
     - always link statically with external libraries (such as glib2)
     - will not set rpath to avoid the following error:
    
    CMake Error at cmake_install.cmake:50 (file):
      file RPATH_CHANGE could not write new RPATH:
    
        /usr/lib
    
      to the file:
    
        /home/fabrice/br-test-pkg/br-arm-full-static/target/usr/bin/tshark
    
      No valid ELF RPATH or RUNPATH entry exists in the file;
    
    Change-Id: I242dc1a091cc211ee891568a2dee5080c9974fba
    Ping-Bug: 15713
    Signed-off-by: Fabrice Fontaine <fontaine.fabrice@xxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/32945
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  dd1245f   ws_pipe: fix memory leaks in spawn arguments handling
     add  900b9f1   CMake: add USE_STATIC option


Summary of changes:
 CMakeLists.txt   | 6 +++++-
 CMakeOptions.txt | 1 +
 2 files changed, 6 insertions(+), 1 deletion(-)