Wireshark-commits: [Wireshark-commits] master 51ac104: ws_pipe: fix return value of ws_pipe_spawn_a
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 22 Apr 2019 14:57:34 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=51ac1047a7e434a0b2e264780b2fa31f1d986898
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

51ac104 by Peter Wu (peter@xxxxxxxxxxxxx):

    ws_pipe: fix return value of ws_pipe_spawn_async on error path
    
    The function returns a GPid, not a gboolean. Callers (mmdbresolv and
    extcap) only assume WS_INVALID_PID to be invalid (as documented).
    
    Change-Id: I40b491272a451f569864fa3259009d6d3fcce772
    Fixes: v2.5.1rc0-413-g1a0987904f ("Generalize our process spawning code.")
    Reviewed-on: https://code.wireshark.org/review/32933
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Tomasz Moń <desowin@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  c77ee00   rpm: update rpm package dependencies and spec to work on current os versions
     add  51ac104   ws_pipe: fix return value of ws_pipe_spawn_async on error path


Summary of changes:
 wsutil/ws_pipe.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)