Wireshark-commits: [Wireshark-commits] master 82d24d9: Qt: Fix deadlock in extcap toolbar creation
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 20 Apr 2019 07:02:51 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=82d24d907ae07b2cb9a558ec12a1f0cb3c47e0cb
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

82d24d9 by Tomasz Moń (desowin@xxxxxxxxx):

    Qt: Fix deadlock in extcap toolbar creation
    
    Deadlock happened if extcap was writing to control pipe before it sent
    the pcap data and the pipe buffer was not able to hold all the data.
    The solution is to start reading data from extcap control pipe in
    capture prepare.
    
    This bug was introduced in 018f6bff18785a1c3971a1ccfe3b1b5243d4d154
    which was reviewed on https://code.wireshark.org/review/23211
    Unfortunately neither the commit message nor the review contains any
    explaination why it delays the extcap control pipe opening.
    
    Bug: 15261
    Change-Id: I10d006128f6eb7d63f751d230edbd905eb46416b
    Reviewed-on: https://code.wireshark.org/review/32898
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  7432d6f   ZEBRA: show correct Zebra route IPv6 source prefix
     add  82d24d9   Qt: Fix deadlock in extcap toolbar creation


Summary of changes:
 ui/qt/main_window_slots.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)